Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracts ghcide-tests and migrate it to use hls-test-utils #4173

Closed
31 tasks done
soulomoon opened this issue Apr 13, 2024 · 3 comments · Fixed by #4176
Closed
31 tasks done

Extracts ghcide-tests and migrate it to use hls-test-utils #4173

soulomoon opened this issue Apr 13, 2024 · 3 comments · Fixed by #4176
Assignees
@soulomoon
Labels
flaky test type: enhancement New feature or request

Comments

@soulomoon
Copy link
Collaborator

soulomoon commented Apr 13, 2024 •
edited
Loading

I think we should pick up #3315,
This can be served as part of #3736,
Extracts ghcide-tests, and migrate the test to use hls-test-utils. This can be served as a pre-step to move the all the functionalities of ghcide to the stand alone plugin #2979

Some benifits:

  1. Removal of code duplication.
  2. Test speed up, we can refactor the test that is doing unconditional wait along the way.
  3. Test correctness, we can refactor some tests that are not designed properly.

When I have done a proof of concept of #2979,
I migrate some of the tests to use hls-test-utils, I have some positive result, some tests can be run 2 to 3 times faster.

Jobs that need to be done
@soulomoon
Copy link
Collaborator Author

Since the number of test are so large.
IMO, a workable solution is that we refactor one test file at a time, smooth the transition from ghcide-test-util to hls-test-util.

@soulomoon soulomoon linked a pull request Apr 14, 2024 that will close this issue
move ghcide-tests to haskell-language-server.cabal and make it depend on hls-test-utils #4176
Merged
@soulomoon soulomoon mentioned this issue Apr 14, 2024
Merged
@soulomoon soulomoon mentioned this issue Apr 19, 2024
Merged
@soulomoon soulomoon reopened this Apr 19, 2024
@soulomoon soulomoon self-assigned this Apr 19, 2024
This was referenced Apr 27, 2024
Merged
Open
michaelpj pushed a commit that referenced this issue Apr 29, 2024
@soulomoon
[Migrate DependentFileTest] part of #4173 Migrate ghcide tests to hls…
a3e4b95 
… test utils (#4195)

* wip trace flaky

* clena up trace

* cleanup

* cleanup
michaelpj pushed a commit that referenced this issue Apr 30, 2024
@soulomoon
[merge hls-test-utils and ghcide-test-utils] part of #4173 Migrate gh…
c7f8ced 
…cide tests to hls test utils (#4197)

* pull ghcide-bench out of ghcide and merge some of the hls-test-utils with ghcide-tests

* fix style
soulomoon added a commit that referenced this issue May 2, 2024
@soulomoon
[Migrate IfaceTests] part of #4173 Migrate ghcide tests to hls test u…
877e75c 
…tils and use canonicalizePath path in tmp dir in hls-test-utils (#4201)

* use canonicalizePath path in tmp dir in hls-test-utils

* migrate IfaceTests to hls-test-utils
soulomoon added a commit that referenced this issue May 2, 2024
@soulomoon
Migrate FindDefinitionAndHoverTests and HighlightTests part of #4173 …
75cb0b9 
…and fix HighlightTests (#4202)

* migrate FindDefinitionAndHoverTests

* migrate highlighttests

* fix highlight
@soulomoon soulomoon mentioned this issue May 11, 2024
Merged
soulomoon added a commit that referenced this issue May 13, 2024
@soulomoon @fendor
[Migrate diagnosticTests] part of #4173 Migrate ghcide tests to hls t…
61fd5c4 
…est utils (#4207)

* [x] migrate diagnosticTests, figure out how to pass `--test-no-kick`. 
* [x] migrate openCloseTests
* [x] Lift a few functions from ghcide-test-utils to hls-test-utils
* [x] fixed `deeply nested cyclic module dependency`
* [x] modify `runSessionWithServer'` and ghcIde arguments to admit additional a switch for `no-kick`.

---------

Co-authored-by: fendor <fendor@users.noreply.github.com>
fendor pushed a commit that referenced this issue May 14, 2024
@soulomoon
[Migrate BootTests] part of #4173 Migrate ghcide tests to hls test ut…
a1fe52f 
…ils (#4227)

* migrate boot test

* add comment
@soulomoon soulomoon mentioned this issue Jun 1, 2024
Merged
@soulomoon
Copy link
Collaborator Author

done !

@jhrcek
Copy link
Collaborator

jhrcek commented Jun 9, 2024

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulomoon soulomoon

Labels
flaky test type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@jhrcek @soulomoon