Merge pull request #307 from bgamari/wip/T306

fork-exec: Don't double-close parent fds
haskell · Mar 31, 2024 · a6b7cc6 · a6b7cc6
2 parents a590acd + 8a9bf8b
commit a6b7cc6
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/cbits/posix/fork_exec.c b/cbits/posix/fork_exec.c
@@ -335,16 +335,8 @@ do_spawn_fork (char *const args[],
         // our responsibility to reap here as nobody else can.
         waitpid(pid, NULL, 0);
 
-        // Already closed child ends above
-        if (stdInHdl->behavior == STD_HANDLE_USE_PIPE) {
-            close(stdInHdl->use_pipe.parent_end);
-        }
-        if (stdOutHdl->behavior == STD_HANDLE_USE_PIPE) {
-            close(stdOutHdl->use_pipe.parent_end);
-        }
-        if (stdErrHdl->behavior == STD_HANDLE_USE_PIPE) {
-            close(stdErrHdl->use_pipe.parent_end);
-        }
+        // No need to close stdin, et al. here as runInteractiveProcess will
+        // handle this. See #306.
 
         pid = -1;
     }