Move tests to separate process-tests package & update CI to use GitHub actions #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sheaf
force-pushed
the
ci
branch
5 times, most recently
from
0cc4137
to
6751549
Compare
This commit moves the process testsuite to a separate package.
The rationale is that later commits require the test-suite to use a
Custom setup in order to work around Cabal bug #9854. This introduces a
setup-depends dependency on the Cabal library, and we would very much
like to avoid the dependency cycle:
Cabal depends on process
process depends on Cabal
Instead, splitting up the test-suite, we have:
Cabal depends on process
process-tests depends on process and on Cabal
To run the test-suite, you can use either of the following commands:
> cabal run process-tests:test
> stack test process-tests
There are a few other auxiliary changes, such as:
- Using Cabal version >= 2.4 in the .cabal files,
and fixing the associated warnings,
- Using the CPP mingw32_HOST_OS define to check for Windows;
this avoids having to define the same variable twice in two
different packages.
|
This PR is ready now. The previously occurring build failures were due incorrect lower bounds in the |
tomjaguarpaw
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit moves the test-suite to a separate package. The rationale is that other work, such as #308, requires the test-suite to use a Custom setup in order to work around Cabal bug #9854. If we don't split up the test-suite into a separate package, this would introduce a setup-depends dependency on the Cabal library, which would create a gnarly dependency cycle between
Cabalandprocess.The second commit rewrites the CI script. I did this because I couldn't figure out how to provision the
Caballibrary (needed by #308) across GHC versions with the current CI infrastructure.There are a few other auxiliary changes, such as:
this avoids having to define the same variable twice in two different packages.