Use prettyprinter instead of ansi-wl-pprint #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
commented
Jun 2, 2023
| @@ -109,7 +109,7 @@ import Data.These (These (..)) | |||
| -- primitive | |||
| import qualified Data.Primitive as Prim | |||
|
|
|||
| #if MIN_VERSION_base(4,9,0) | |||
| #if MIN_VERSION_base(4,17,0) | |||
There was a problem hiding this comment.
I'm unsure if I was doing something weird, but this module seems to only exist in base >=4.17, that's why I updated this cpp
There was a problem hiding this comment.
It is shimmed in https://hackage.haskell.org/package/data-array-byte
phadej
reviewed
Jun 6, 2023
There was a problem hiding this comment.
I won't accept this change as such. It's a breaking change.
I have thought about how to do this and the streps are:
- add
prettyprinterdependency (behind a manual flag) and functionality similarly how there are printers usingprettyandansi-wl-pprint. - make
ansi-wl-pprintdependency behind a flag too (enabled) - make
ansi-wl-pprintflag disabled by default. Later, as that will be a breaking change.
But I'm unsure about this. Maybe I won't do flags, but rather a companion packages.
| @@ -109,7 +109,7 @@ import Data.These (These (..)) | |||
| -- primitive | |||
| import qualified Data.Primitive as Prim | |||
|
|
|||
| #if MIN_VERSION_base(4,9,0) | |||
| #if MIN_VERSION_base(4,17,0) | |||
There was a problem hiding this comment.
It is shimmed in https://hackage.haskell.org/package/data-array-byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't do anything fancy, just "inlining" what I found in
prettyprinter-compat-ansi-wl-pprint.