Revert "Specify /bin/zsh when creating a new user (#755)" #799
Conversation
This reverts commit 7fd5170.
WalkthroughThe changes in this pull request modify the SSH daemon configuration script for the Home Assistant Community Add-on for Advanced SSH & Web Terminal. The primary alteration involves changing the default shell for user accounts from Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
ssh/rootfs/etc/s6-overlay/s6-rc.d/init-ssh/run (1)
102-102: Approve: Change default shell to /bin/shThis change from
/bin/zshto/bin/shaddresses the reported issue of users being unable to switch to the root account. Using/bin/shas the default shell is more universal and less likely to cause compatibility issues.Consider the following recommendations:
- Document this change in the add-on's changelog or documentation to inform users about the default shell change.
- Consider adding a configuration option that allows users to choose their preferred shell (e.g.,
ssh.default_shell). This would provide flexibility for users who prefer Zsh or other shells.Example implementation for a configurable shell:
default_shell=$(bashio::config 'ssh.default_shell' "/bin/sh") adduser -D "${username}" -s "${default_shell}" \ || bashio::exit.nok 'Failed creating the user account'This approach would maintain the fix while offering users more control over their environment.
sinclairpaul
added
the
bugfix
This reverts commit 7fd5170.
Proposed Changes
Related Issues
Summary by CodeRabbit
New Features
/bin/zshto/bin/shduring user creation for enhanced compatibility.Bug Fixes
Chores