Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/bin/zsh bu Default #760

Closed

Conversation

simonepittis
Copy link

@simonepittis simonepittis commented Jul 5, 2024

Proposed Changes

from /bin/sh to /bin/zsh by Default

Related Issues

(Github link to related issues or pull requests)

Summary by CodeRabbit

  • New Features
    • Updated the default shell for non-root users from /bin/sh to /bin/zsh to enhance user experience with more features and a better interface.

Copy link

coderabbitai bot commented Jul 5, 2024

Walkthrough

In the s6-overlay setup, the user's shell for non-root users has been updated from /bin/sh to /bin/zsh. This change affects the init-ssh/run script, which is responsible for initializing SSH services within the s6-overlay system.

Changes

File Path Change Summary
.../init-ssh/run Changed non-root user shell from /bin/sh to /bin/zsh

Sequence Diagram(s)

No sequence diagrams are provided as the changes are too simple.

Poem

In scripts where shadows cast,
A change of shell, now zsh at last,
For non-root users, swift and right,
/bin/zsh shall be their light.
With paws of code, we celebrate,
A smoother shell, a better state.
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a44db0d and cd2c50d.

Files selected for processing (1)
  • ssh/rootfs/etc/s6-overlay/s6-rc.d/init-ssh/run (1 hunks)
Additional comments not posted (1)
ssh/rootfs/etc/s6-overlay/s6-rc.d/init-ssh/run (1)

102-102: Change default shell for non-root users to /bin/zsh.

This change updates the default shell for non-root users from /bin/sh to /bin/zsh. Ensure that all necessary configurations and dependencies for zsh are in place and that this change does not introduce any compatibility issues with existing setups.

@sinclairpaul
Copy link
Member

Exact duplicate of #755

@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants