Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make md5 and dates attributes optional when uploading to jottacloud #99

Open
ttyridal opened this issue Feb 2, 2016 · 6 comments
Open

Comments

@ttyridal
Copy link

ttyridal commented Feb 2, 2016

and they should be allowed to be None (ie not send them). Seems like the jotta servers only actually requires JSize

[updated:
They should be possible to not send because jotta will then complete the fields for us. This is of particular interest on md5. When we specify md5 in the post, jotta servers will do verification and mark the file as corrupt. Without the md5 it will always accept the file and we can do the comparison on our end.
]

Maybe allow for specifying size and accept generators as the fileobject when at it?

The apparent use-case here is on the fly encryption.

@havardgulldahl
Copy link
Owner

@ttyridal, This is really interesting, have you tested this? It would allow for all kinds of interesting uses.

@ttyridal
Copy link
Author

it's related to Issue #100

I did some research/testing to confirm that it's working before the priorities shifted.

@havardgulldahl havardgulldahl changed the title add md5 and dates argument to JFS.up make md5 and dates attributes optional when uploading to jottacloud Jun 11, 2016
@havardgulldahl
Copy link
Owner

I'm hoping this will fix #11, too.

Looking into it.

@havardgulldahl
Copy link
Owner

@ttyridal FWIW, I'd be happy to see your testing code, if there is anything we can use in jottalib. Maybe put up a gist, perhaps?

@havardgulldahl
Copy link
Owner

@ttyridal I absolutely get why setting the md5 hash to None is really helpful, but what's the advantage of omitting the date?

@ttyridal
Copy link
Author

Date must be specified as an argument if the source is not a file. I don't really remember if this is the reason, but typical case would be time.now(). might as well provide that as a default. ie None = mdate if a file, time.now() otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants