-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player unfrozen immediately after firing The Epic and talking to NPC #2457
Comments
Maybe I'm misunderstanding, but I can't reproduce whatever the issue is here. I fixed the fact that you can keep open her menu just before she notices the fire before release. There must be some other tiny edge case here. |
I see! |
But you're not holding The Epic in the screenshot? What did you actually do? |
This will only happen if you fire The Epic when it is charged and then talk to an NPC before the camera shaking has stopped. Classic problem of mutable values where we set the player to freeze so we can shake the camera on The Epic attack, but then also set the player to freeze when we talk to an NPC before The Epic code timer triggers and sets the player movement freeze to off again. I could write a fix for this, but it would be ugly and it wouldn't be the right fix which involves rewriting these player behaviours in the Clojure port later in immutable data structures so we don't have this problem. We knew the camera shaking was a hack when we implemented it and we knew it would probably break things. So here we are with something broken, but because it's so minor I'm not going to touch it. I'll leave the bug open in case anyone else feels like writing a fix after my description of the problem. |
Once the blacksmith's house is burn.
Wait Hilda stop crying and then talk to him.
Sometimes the animation of the dialogue stops.
Very odd thing by launching the game.
If I talk to Hilda, animation of the dot of interrogation gets going.
The text was updated successfully, but these errors were encountered: