Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller support and Global keys #2389

Merged
merged 1 commit into from
May 24, 2015
Merged

Conversation

niamu
Copy link
Member

@niamu niamu commented May 22, 2015

Resolves #1978 regarding global keys for selecting and going back.

It's not a perfect solution as ENTER will now always function as JUMP. But that's not exactly a problem.

This change also starts to cleanup some dead code and add the beginnings of the structure necessary for gamepad control support (#2356).

@niamu niamu added the wip label May 22, 2015
@niamu niamu changed the title Global Enter/Escape keys Controller support and Global keys May 23, 2015
@niamu
Copy link
Member Author

niamu commented May 23, 2015

No analog stick support at the moment, but otherwise, very usable.

@niamu niamu removed the wip label May 23, 2015
@8bitgentleman
Copy link
Contributor

First off this is dope, the game feels much more natural when played with a controller.
Alright I've tested my Dualshock 3 and USB SNES controllers with this. The PS3 controller works perfectly as long as it was correctly set up in the OS. I forgot to set it up at first and it kept disconnecting and reconnecting which turned out to be my fault not Hawkthorne's. The SNES controller does not work. This is because the USB SNES controllers identify themselves as joysticks not gamepads. Love sees gamepads and joysticks as different things apparently.

@niamu
Copy link
Member Author

niamu commented May 23, 2015

I have no idea if this latest change is sufficient to allow for SNES support. My guess is that it won't register button presses on a controller that identifies as a joystick rather than a gamepad, but I can't test that.

@8bitgentleman
Copy link
Contributor

Your guess is correct, the SNES keypresses do not register.

@niamu
Copy link
Member Author

niamu commented May 24, 2015

@8bitgentleman, when you have the time to join me on IRC, we can walk through some debugging together and figure out how to finish this up.

@niamu niamu force-pushed the controller branch 2 times, most recently from 3b0b65c to a810c4e Compare May 24, 2015 17:06
@niamu
Copy link
Member Author

niamu commented May 24, 2015

We have controller support now for Xbox and PlayStation controllers as well as the mapping for the Retro SNES controller. No analog stick support as of yet, but the game is playable, so we're merging this in now.

niamu added a commit that referenced this pull request May 24, 2015
Controller support and Global keys
@niamu niamu merged commit 0217d6c into hawkthorne:master May 24, 2015
niamu added a commit to niamu/hawkthorne-journey that referenced this pull request May 24, 2015
Controller support and Global keys
@niamu niamu deleted the controller branch May 24, 2015 20:33
@niamu niamu mentioned this pull request May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions from a Concerned Joe
2 participants