Added winston file transport and updated console.log usage #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Move log folder to base folder, add gitignore, reduce chunk size to 2 mb. |
|
Oof wait I need to remove some things |
adamegyed
force-pushed
the
Winston-refactor
branch
from
7142e26
to
9e81b92
Compare
| @@ -1,5 +1,8 @@ | |||
|
|
|||
There was a problem hiding this comment.
Why the extra whitespace here?
| new winston.transports.File({ | ||
| level: 'debug', | ||
| filename: `./logs/nantucket.log`, | ||
| handleExceptions: true, |
There was a problem hiding this comment.
Can multiple transports handle exceptions or will that break things?
| @@ -1,4 +1,6 @@ | |||
| // src | |||
| import * as winston from "winston"; | |||
There was a problem hiding this comment.
Does this import scheme work with current JS stuff?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67