From ee595357e87425ba572416296b30127bf21a00c5 Mon Sep 17 00:00:00 2001 From: hayes Date: Tue, 30 Mar 2021 20:36:03 -0500 Subject: [PATCH] refactor: replaced liquid loader with copy plugin --- CHANGELOG.md | 9 +++++++++ package.json | 2 +- src/server/app.js | 7 ++++++- src/webpack/parts/core.js | 8 -------- 4 files changed, 16 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 796b88c..0a1905f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,12 @@ +## [2.1.1](https://github.com/hayes0724/shopify-packer/compare/2.1.0...2.1.1) (2021-03-31) + + +### :hammer: Code Refactoring + +* replaced liquid loader with copy plugin ([13160b3](https://github.com/hayes0724/shopify-packer/commit/13160b32d4cab733f5607470e1b2c47daf2583d7)) + + + # [2.1.0](https://github.com/hayes0724/shopify-packer/compare/2.0.13...2.1.0) (2021-03-31) diff --git a/package.json b/package.json index a66974e..c390dcd 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@hayes0724/shopify-packer", - "version": "2.1.0", + "version": "2.1.1", "bin": { "packer": "cli/index.js" }, diff --git a/src/server/app.js b/src/server/app.js index 17c2213..8e39b09 100644 --- a/src/server/app.js +++ b/src/server/app.js @@ -2,12 +2,17 @@ const webpackDevMiddleware = require('webpack-dev-middleware'); const webpackHotMiddleware = require('webpack-hot-middleware'); const corsMiddleware = require('cors'); const express = require('express'); +const isHotUpdateFile = require('./is-hot-update-file'); class App { constructor(compiler) { const app = express(); - app.webpackDevMiddleware = webpackDevMiddleware(compiler, {}); + app.webpackDevMiddleware = webpackDevMiddleware(compiler, { + writeToDisk: (filePath) => { + return !isHotUpdateFile(filePath); + }, + }); app.webpackHotMiddleware = webpackHotMiddleware(compiler, { log: false, }); diff --git a/src/webpack/parts/core.js b/src/webpack/parts/core.js index a2e9a79..e32c3da 100644 --- a/src/webpack/parts/core.js +++ b/src/webpack/parts/core.js @@ -23,14 +23,6 @@ const core = { }, module: { rules: [ - { - test: /\.(liquid|json)$/, - exclude: [/(css|scss|sass)\.liquid$/, ...config.get('commonExcludes')], - type: 'asset/resource', - generator: { - filename: '[name][ext]', - }, - }, { test: /\.(ts|js)$/, loader: 'babel-loader',