Fixes stuck deployment #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR only addresses the issue on K8s. I did not check Docker to see if the issue exists. |
|
issue exists on docker too |
|
Ah. I read through the Docker compose file and it looks alright to me though 🤔 Can you check what address is being used in the WebSocket communication in your deployment? |
muradbozik
reviewed
Nov 14, 2024
Comment on lines
-59
to
+62
| value: ws://transactor:3333;ws://localhost:3333 | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| name: huly-config | ||
| key: TRANSACTOR_URL |
There was a problem hiding this comment.
This should stay unchanged, account pod doesn't need to use ingress to reach transactor service.
TRANSACTOR_URL in config needs to be used by frontend. That change should be done in frontend code, not in deployment manifests. Last time I checked it (front pod) was using localhost which would cause problem when reaching frontend through proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #45 Thanks to @muradbozik for pointing out the solution and @FireflyHacker for confirming the solution.
Environment variable updates:
kube/account/account-deployment.yaml: Changed theTRANSACTOR_URLenvironment variable to use aconfigMapKeyRefinstead of a hardcoded value.Ingress settings updates:
kube/transactor/transactor-ingress.yaml: Added annotations to enable WebSocket support and set proxy timeouts. Updated the host and port number to match the service configuration.Service port configuration:
kube/transactor/transactor-service.yaml: Changed the service port from 80 to 3333 and set the service type toClusterIP.