remove use of reflection based toString generator #1359
Merged
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reflection based toString generator fails on some modern jvms as apache commons tries to parse out the version of Java, but fails due to outdated assumptions. Not clear why it's inmportant to have a toString method here, but replacing with an autogenerated one should solve #1358. Implementation excludes logger and sink form toString as it's unclear how they would be useful.
hcoles
force-pushed
the
bug/remove_reflective_equals
branch
from
5b4df4e
to
9c9bba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reflection based toString generator fails on some modern jvms as apache commons tries to parse out the version of Java, but fails due to outdated assumptions.
Not clear why it's inmportant to have a toString method here, but replacing with an autogenerated one should solve #1358. Implementation excludes logger and sink form toString as it's unclear how they would be useful.