Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with setting read_io to same obj twice #915

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 25, 2023

Motivation

Fix #914.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff30e12) 88.32% compared to head (0da71eb) 88.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #915   +/-   ##
=======================================
  Coverage   88.32%   88.33%           
=======================================
  Files          45       45           
  Lines        9280     9283    +3     
  Branches     2651     2651           
=======================================
+ Hits         8197     8200    +3     
  Misses        765      765           
  Partials      318      318           
Files Changed Coverage Δ
src/hdmf/container.py 91.54% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested review from bendichter and oruebel July 25, 2023 02:14
@rly rly merged commit 64a444f into dev Jul 25, 2023
26 checks passed
@rly rly deleted the fix_double_read_error branch July 25, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Calling io.read() more than once results in error
2 participants