Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to url safe base64 #7

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

JProgrammer
Copy link
Contributor

Pagination requests are often carried via query parameters for GET requests, as such usingstrict_decode64 will require escaping for some characters and the use of padding = is not needed to carry the information.

@fatkodima
Copy link
Collaborator

Can you please elaborate more on what the problem is, with an example, and probably add a test case and changelog entry?

@JProgrammer
Copy link
Contributor Author

This is a good summary of the problem with base64 and urls, https://base64.guru/standards/base64url

I'm not sure it's explicitly testable unless test of base Ruby is desired, though I can update the change log and read me to reflect the change

@fatkodima fatkodima merged commit 742180a into healthie:master May 20, 2024
4 checks passed
@fatkodima
Copy link
Collaborator

Thank you very much for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants