Updated spec tests and description of Duration handling #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated test versions to 8.3.0 and clarified tests for TAG_INVALID
Merged NODE_NAME_EMPTY into TAG_INVALID
Lower the schema version on two tests back
Made hed_error_codes.json only contain codes with json files
Add hedID validation tests
Updating the JSON tests to have all fields
Updated tests to include warning and alt_code in non-schema tests
Updated the tests with additional alt-codes
Definition no longer is required to have inner group.
Updated error in Appendix B to reflect Definition change
Additional changes to the tests.
Corrected typos in the JSON spec-tests
Modified definition test with no group
VisLab
added a commit
that referenced
this pull request
Sep 13, 2024
* Updated tests and descriptions of duration handling (#620) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> * Updated spec tests and description of Duration handling (#621) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> * Reran consolidation tests --------- Co-authored-by: IanCa <ianrcallanan@gmail.com>
VisLab
added a commit
that referenced
this pull request
Sep 13, 2024
* Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group * Updated consolidated json tests (#622) * Updated tests and descriptions of duration handling (#620) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> * Updated spec tests and description of Duration handling (#621) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> * Reran consolidation tests --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> --------- Co-authored-by: IanCa <ianrcallanan@gmail.com>
VisLab
added a commit
that referenced
this pull request
Sep 13, 2024
* Reran consolidation tests * Updated JSON tests (#623) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group * Updated consolidated json tests (#622) * Updated tests and descriptions of duration handling (#620) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> * Updated spec tests and description of Duration handling (#621) * Updated test versions to 8.3.0 and clarified conditions for TAG_INVALID * Merged NODE_NAME_EMPTY into TAG_INVALID * Corrected additional NODE_NAME_EMPTY_LINKS * Lower the schema version on two tests back * Made hed_error_codes.json only contain codes with json files * Add hedID validation tests * Updated some of invalid characters * Updated the JSON tests to have all fields * Updated tests to include warning and alt_code in non-schema tests * Updated the tests with additional alt-codes * Definition may have no inner group * Minor update in appendix B errors * Minor changes to tests * Corrected a typo in the specification * Correction to curly brace test * Modified the test for definition with no group --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> * Reran consolidation tests --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> --------- Co-authored-by: IanCa <ianrcallanan@gmail.com> * Updated the tests to correct syntax problems --------- Co-authored-by: IanCa <ianrcallanan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.