Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Remove default level of new adventures #6095

Merged
merged 6 commits into from
Jan 13, 2025
Merged

💻 Remove default level of new adventures #6095

merged 6 commits into from
Jan 13, 2025

Conversation

boryanagoncharenko
Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko commented Jan 9, 2025

This PR removes the pre-selected level 1 when a new adventure is created.

Fixes #5922

How to test
Go to the for-teachers page and create a new adventure. When the form appears, check that no levels are pre-selected. Check that you cannot save an adventure without setting levels. Now try updating an existing adventure and again check that you cannot save an adventure if there isn't at least 1 level selected.

@boryanagoncharenko boryanagoncharenko marked this pull request as draft January 9, 2025 16:31
Copy link
Contributor

mergify bot commented Jan 10, 2025

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@boryanagoncharenko boryanagoncharenko marked this pull request as ready for review January 13, 2025 11:58
Copy link
Contributor

mergify bot commented Jan 13, 2025

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c50cc1e into main Jan 13, 2025
11 checks passed
@mergify mergify bot deleted the cust_adv_5922 branch January 13, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💻Don't autoselect level 1 and language English when creating a custom adventure
2 participants