-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds more projects description checks and refac to check everything per project #312
Adds more projects description checks and refac to check everything per project #312
Conversation
…er project Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Instead it returns 1 if any project fails to pass the checks Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
The checker script does not raise anymore if a project fails so we always check all projects and it makes the output more readable and natural. |
That was fast! I didn't expect you to do this until at least next week. Lol We need to loosen these checks, however. It probably shouldn't check anything in |
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@sapols, my bad, it makes sense to skip |
@jeandet Ah I see. You just interpreted |
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@sapols, I removed the check and just added a simple warning if a project has 0 keywords (which should be suspicious). GeospaceLAB project issue seems legit, its documentation field is set to Later in another PR, I'll also check that projects only uses documented fields (should help to spot any typo). |
@jeandet Thanks! About GeospaceLAB, yeah people mix up those URLs and strings sometimes. Their documentation status is in fact "Good" so it's the Once you fix GeospaceLAB, there won't be any more errors right? If every project in |
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@sapols Sure, I fixed GeospaceLAB and made keyword absence an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks so much!
@sapols a little more work for you or related projects maintainers 😅: