Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qrcode #345

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Qrcode #345

merged 3 commits into from
Oct 1, 2024

Conversation

sandyfreelance
Copy link
Contributor

Adds a static QR code pointing to heliocloud.org to the logos directory.

@sandyfreelance sandyfreelance merged commit 63231e9 into main Oct 1, 2024
1 check passed
@sandyfreelance sandyfreelance deleted the qrcode branch October 1, 2024 17:51
@sapols
Copy link
Contributor

sapols commented Oct 1, 2024

Wait sorry, what happened here @sandyfreelance ? Why is projects.yml all changed by this PR again? And where is this new QR code image being used? I would've liked a chance to understand this PR before you merged it.

@sandyfreelance
Copy link
Contributor Author

Ack, error! I put this in the wrong repo. Revert the merge! (Thought this was the heliocloud website, not the heliocloudPy website)

More formally, how the heck did I have rights to merge into main? I suggest we add a mandatory check on all merges to main, that they have to be approved by one other person.

@sandyfreelance sandyfreelance mentioned this pull request Oct 1, 2024
@sandyfreelance
Copy link
Contributor Author

I ran a revert, hopefully that cleaned up the codebase.

@sandyfreelance
Copy link
Contributor Author

This was scary. How to lock down main so only you/Julie can approve merges to main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants