fix: collection hash indexing #2
Conversation
| let collection_raw = keys | ||
| .get(collection_index) | ||
| .ok_or(BlockbusterError::InstructionParsingError)? | ||
| .0; |
There was a problem hiding this comment.
This is just an FYI, that I also had a draft PR for blockbuster that added explicit support for Verify and Unverify collection: github.com/metaplex-foundation/pull/21.
But I ended up not needing the change for the ordering PR since I added a verify flag and additional sequence number to manage the data out of order.
I don't think this results in a change for what you are doing, I'm just telling you as more of an FYI.
I suppose one thing you could consider is just using index 8 from the accounts to get collection every time, since its always in the same accounts location for VerifyCollection, UnverifyCollection, and SetAndVerifyCollection.
There was a problem hiding this comment.
Is there a difference between the index 8 account and the one in the instruction args? Why do both exist?
| let _args: MetadataArgs = MetadataArgs::try_from_slice(ix_data)?; | ||
| let collection: Pubkey = Pubkey::try_from_slice(ix_data)?; |
There was a problem hiding this comment.
Yes this never had the right offset for MetadataArgs or collection, which you figured out, and yesterday I found that SetAndVerify doesn't pass this parsing on mainline at the moment.
Overview
5ZKjPxm3WAZzuqqkCDjgKpm9b5XjB9cuvv68JvXxWThvJaJxcMJgpSbYs4gDA9dGJyeLzsgNtnS6oubANF1KbBm" for asset2WjoMU1hBGXv8sKcxQDGnu1tgMduzdZEmEEGjh8MZYfC. This txn sets and verifies a collection for a cNFT that does not have a collection.7nK9a2DSDZ4Gh6DatmxGJmuLiDEswaY9bYSSPTtQppk7PtLKXYE84jWzm7AC4G1fpa831GaXuXcn5n5ybWqB4e5and asset2gEbvG3Cb6JRaGWAx5e85Bf5z4u37EURBeyPBqXDzZoY. This txn unverifies a cNFT with a verified collection.Testing