Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional args tree and leafIndex for decompressed assets #91

Merged
merged 6 commits into from
Jul 19, 2023
Merged

feat: add optional args tree and leafIndex for decompressed assets #91

merged 6 commits into from
Jul 19, 2023

Conversation

tahsintunan
Copy link

@tahsintunan tahsintunan commented Jul 13, 2023 •
edited
Loading

Overview

  • For decompressed assets, the asset table does not contain a tree id. So we provide optional args tree and leafIndex to query decompressed assets

Testing

  • Testing performed locally to validate the changes

@tahsintunan tahsintunan changed the title refactor feat: add optional args tree and leafId for decompressed assets Jul 18, 2023
@tahsintunan tahsintunan changed the title feat: add optional args tree and leafId for decompressed assets feat: add optional args tree and leafIndex for decompressed assets Jul 18, 2023
NicolasPennie
NicolasPennie reviewed Jul 18, 2023
View reviewed changes
das_api/src/api/api_impl.rs Outdated Show resolved Hide resolved
das_api/src/api/api_impl.rs Outdated Show resolved Hide resolved
@tahsintunan tahsintunan marked this pull request as ready for review July 18, 2023 22:57
@tahsintunan tahsintunan merged commit 6a2081d into helius Jul 19, 2023
2 checks passed
@tahsintunan tahsintunan deleted the get-sigs branch July 19, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasPennie NicolasPennie NicolasPennie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tahsintunan @NicolasPennie