adding option to add extra nodes to each asg #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crhuber Could I get some eyes on this please. Its something I need as a use case where I work. |
|
@chadlwilson are you able to review this please? |
|
I'm not a maintainer here so can't review things. I'm also not actively using eks-rolling-update any longer so not well set up to give useful input and think about how all the options interact with one another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cluster-autoscaler is disabled during the upgrade process this causes new pods being scheduled onto the cluster to be stuck in Pending until the script finishes running and cluster autoscaler is turned back on. Adding additional nodes to the cluster prior to the upgrade can help circumvent this issue and then when cluster auto-scaler is turned back on it can remove unneeded nodes. This is especially needed in Production Cluster where upgrades can take hours and we still want to account for being able to schedule new Pods on the cluster.