Fix: jQuery XSS Security Vulnerability: CVE-2020-11023 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency of HSDS React which is used in Storybook stories
cen10
approved these changes
Nov 3, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update bumps the version of jQuery to
>= 3.5.0because jQuery< 3.5.0had an XSS security vulnerability. See: GHSA-jpcq-cgw6-v4j6 for more details. Since jQuery was a development dependency and not included in the Brigade library, this security update is not critical.This update also adds a new dependency: HSDS Illos. The Storybook uses an older version of HSDS React (V2) which requires HSDS Illos as a peer dependency. This new addition satisfied that requirement.
Neither of these changes impact the current version of the Brigade library on NPM. They do however constitute some improvements to this repository and the development environment.