better naming

hemerajs · Jul 31, 2018 · 02fd776 · 02fd776
1 parent bba8ffb
commit 02fd776
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -19,11 +19,11 @@ const internals = {
 async function register(server, options) {
   const settings = Hoek.applyToDefaults(internals.defaults, options)
 
-  const createHemera = !options.hemeraInstance
+  const useHemeraInstance = !!options.hemeraInstance
 
-  const hemera = createHemera
-    ? new Hemera(Nats.connect(settings.nats), settings.hemera)
-    : options.hemeraInstance
+  const hemera = useHemeraInstance
+    ? options.hemeraInstance
+    : new Hemera(Nats.connect(settings.nats), settings.hemera)
 
   hemera.on('serverResponseError', error =>
     server.log(['hemera', 'serverResponseError'], error)
@@ -32,7 +32,7 @@ async function register(server, options) {
     server.log(['hemera', 'clientResponseError'], error)
   )
 
-  if (createHemera && options.plugins) {
+  if (useHemeraInstance === false && options.plugins) {
     options.plugins.forEach(plugin => {
       if (plugin.options) {
         hemera.use(plugin.register, plugin.options)
@@ -79,7 +79,7 @@ async function register(server, options) {
     return hemera.close()
   })
 
-  if (createHemera) await hemera.ready()
+  if (useHemeraInstance === false) await hemera.ready()
 }
 
 internals.handler = function(route, options) {

diff --git a/test/basic-custominstance.js b/test/basic-custominstance.js
@@ -30,7 +30,7 @@ describe('Custom Hemera instance', function() {
     await server.register({
       plugin: HapiHemera,
       options: {
-        hemeraInstance: hemeraInstance
+        hemeraInstance
       }
     })
     await server.stop()
@@ -42,7 +42,7 @@ describe('Custom Hemera instance', function() {
     await server.register({
       plugin: HapiHemera,
       options: {
-        hemeraInstance: hemeraInstance
+        hemeraInstance
       }
     })