Skip to content

Commit

Permalink
Corrent container name in e2e tests (#294)
Browse files Browse the repository at this point in the history
* Corrent container name in e2e tests

The l1 runs geth, not op-geth.

* no more op-geth-l1 in localnet test main.go

* formatted code

---------

Co-authored-by: ClaytonNorthey92 <clayton.northey@gmail.com>
  • Loading branch information
jcvernaleo and ClaytonNorthey92 authored Oct 25, 2024
1 parent 2989b9b commit 1e36374
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 10 deletions.
18 changes: 9 additions & 9 deletions e2e/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ services:
POPM_LOG_LEVEL: "INFO"
POPM_REMINE_THRESHOLD: "1"

op-geth-l1:
geth-l1:
image: "ethereum/client-go@sha256:343cff592e1a9daf99a89261d3263941ff9c3350b62b3ebc0f7c30d35721d905"
ports:
- "8545:8545"
Expand Down Expand Up @@ -191,12 +191,12 @@ services:
dockerfile: "optimism-stack.Dockerfile"
context: "."
depends_on:
- "op-geth-l1"
- "geth-l1"
healthcheck:
test: ["CMD-SHELL", "ls /l2configs/rollup.json"]
environment:
ADMIN_PRIVATE_KEY: "${ADMIN_PRIVATE_KEY}"
OP_GETH_L1_RPC: "http://op-geth-l1:8545"
OP_GETH_L1_RPC: "http://geth-l1:8545"
working_dir: "/tmp"
command:
- "sh"
Expand All @@ -221,7 +221,7 @@ services:
restart_policy:
condition: "any"
depends_on:
op-geth-l1:
geth-l1:
condition: "service_started"
op-geth-l2:
condition: "service_healthy"
Expand All @@ -239,7 +239,7 @@ services:
- "--rpc.port=8547"
- "--p2p.disable"
- "--rpc.enable-admin"
- "--l1=http://op-geth-l1:8545"
- "--l1=http://geth-l1:8545"
- "--l1.rpckind=standard"
- "--l1.trustrpc"
- "--log.level=info"
Expand Down Expand Up @@ -270,10 +270,10 @@ services:
- "--rpc.enable-admin"
- "--max-channel-duration=1"
- "--max-pending-tx=1"
- "--l1-eth-rpc=http://op-geth-l1:8545"
- "--l1-eth-rpc=http://geth-l1:8545"
- "--private-key=${ADMIN_PRIVATE_KEY}"
depends_on:
op-geth-l1:
geth-l1:
condition: "service_started"
op-geth-l2:
condition: "service_healthy"
Expand All @@ -288,7 +288,7 @@ services:
restart_policy:
condition: "any"
depends_on:
op-geth-l1:
geth-l1:
condition: "service_started"
op-geth-l2:
condition: "service_healthy"
Expand All @@ -301,7 +301,7 @@ services:
- "--rollup-rpc=http://op-node:8547"
- "--l2oo-address=${L2OO_ADDRESS}"
- "--private-key=${ADMIN_PRIVATE_KEY}"
- "--l1-eth-rpc=http://op-geth-l1:8545"
- "--l1-eth-rpc=http://geth-l1:8545"

volumes:
l2configs:
Expand Down
8 changes: 7 additions & 1 deletion e2e/monitor/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,16 @@ func monitorRolledUpTxs(ctx context.Context, s *state, mtx *sync.Mutex) {
`

runJs := func(jsi string, layer string, ipcPath string) string {
prefix := "op-"
if layer == "l1" {
prefix = ""
}

container := fmt.Sprintf("e2e-%sgeth-%s-1", prefix, layer)
cmd := exec.Command(
"docker",
"exec",
fmt.Sprintf("e2e-op-geth-%s-1", layer),
container,
"geth",
"attach",
"--exec",
Expand Down

0 comments on commit 1e36374

Please sign in to comment.