Fix race condition in electrumx client

Previously, the request ID stored in the client was incremented while the lock was held, however it was then read without the lock being held.
hemilabs · Feb 26, 2024 · 4a2afcc · 4a2afcc
1 parent 7c778c0
commit 4a2afcc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/hemi/electrumx/electrumx.go b/hemi/electrumx/electrumx.go
@@ -123,13 +123,13 @@ func (c *Client) call(ctx context.Context, method string, params, result any) er
 	defer conn.Close()
 
 	c.mtx.Lock()
-	c.id++
+	id := c.id++
 	c.mtx.Unlock()
 
 	req := &JSONRPCRequest{
 		JSONRPC: "2.0",
 		Method:  method,
-		ID:      c.id,
+		ID:      id,
 	}
 	if params != any(nil) {
 		b, err := json.Marshal(params)