Skip to content

Commit

Permalink
ci: fix go workflow succeeding even if a step fails (#5)
Browse files Browse the repository at this point in the history
The continue-on-error flag appears to be buggy and not well
documented, however it was causing the workflow to be marked as
succeded even if a step failed.
  • Loading branch information
joshuasing authored Feb 27, 2024
1 parent fac6389 commit b3993a0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,21 @@ jobs:
check-latest: true

- name: "Download and verify dependencies"
id: deps
run: make deps

- name: "make race"
continue-on-error: true
run: make race

- name: "make"
continue-on-error: true
if: (success() || failure()) && steps.deps.outcome == 'success'
env:
PGTESTURI: "postgres://postgres:postgres@localhost:5432/postgres?sslmode=disable"
run: |
make
git diff --exit-code
- name: "make web popm"
continue-on-error: true
if: (success() || failure()) && steps.deps.outcome == 'success'
run: |
cd web && make

0 comments on commit b3993a0

Please sign in to comment.