Move internal error into protocol package #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit awkward and probably does not belong here. However, this code is copy and pasted everywhere and pretty brittle. So to prevent reinventing the wheel and bad copy paste it is allowed here.
ClaytonNorthey92
approved these changes
Feb 27, 2024
joshuasing
reviewed
Feb 28, 2024
joshuasing
added
type: refactor
This allows the error to be unwrapped by `errors.Unwrap`. See https://pkg.go.dev/errors#pkg-overview for more information.
joshuasing
approved these changes
Feb 28, 2024
joshuasing
changed the title
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
* Move internal error into protocol package. This is a bit awkward and probably does not belong here. However, this code is copy and pasted everywhere and pretty brittle. So to prevent reinventing the wheel and bad copy paste it is allowed here. Co-authored-by: ClaytonNorthey92 <clayton.northey@gmail.com> Co-authored-by: Joshua Sing <joshua@bloq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a bit awkward and probably does not belong here. However, this code is copy and pasted everywhere and pretty brittle. So to prevent reinventing the wheel and bad copy paste it is allowed here.
Changes
Catch up remaining daemons to use this new api.