Automate Full Network E2E Acceptance Tests #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaytonNorthey92
added
area: test
| @@ -271,6 +271,8 @@ func (s *Server) handleBitcoinBroadcast(ctx context.Context, bws *bfgWs, payload | |||
| tl2, err = pop.ParseTransactionL2FromOpReturn(v.PkScript) | |||
| if err != nil { | |||
| log.Errorf(err.Error()) // handle real error below | |||
| } else { | |||
| break | |||
There was a problem hiding this comment.
this will likely be fixed in @marcopeereboom 's pr #10
ClaytonNorthey92
force-pushed
the
clayton/acceptance
branch
from
5f5e185
to
26a1bb8
Compare
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
jcvernaleo
requested changes
Mar 6, 2024
hey @jcvernaleo - yup! will rebase, though I want to merge #18 first; it will simplify the e2e tests a bit. And I can definitely make the commit message better 👍 |
these include: * PoP transactions get published to Bitcoin, and each contains an OP_RETURN starting with 'HEMI" * PoP transactions are using the correct fee (approx 1 sat/vB) * PoP miner only creates one BTC transaction for each keystone * PoP payouts are calculated for each keystone starting at 25, and payout address matches PoP miner ETH address * Bitcoin Finality for blocks starts at -9 and progresses in step with new Bitcoin blocks * Bitcoin Finality returns same result for last 10 blocks and querying for specific block in that list
ClaytonNorthey92
force-pushed
the
clayton/acceptance
branch
from
26a1bb8
to
68eb49e
Compare
joshuasing
approved these changes
Mar 18, 2024
|
@joshuasing @jcvernaleo I am actually going to close this in favor of #37 ; that's a better way to test, and we can write cleaner automated tests against the local network |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Talking with @max-sanchez , we want to automate his acceptance test cases, these are:
I opted to make this one test case for two reasons:
Changes
Automates the above tests in a single "full network" test. test cases are denoted by comment prefix: "acceptance test case"
fixes #2
fixes #6