Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popmd: remove unused 'handle' func and return err in connectBFG #124

Merged
merged 2 commits into from
May 20, 2024

Conversation

joshuasing
Copy link
Contributor

Summary
Remove unused handle function and return previously unused err in connectBFG.

Changes

  • Remove unused handle function
  • Return previously unused err in connectBFG function (bug)

@joshuasing joshuasing added type: refactor This refactors existing functionality type: bug This is a bug size: XS This change is very small (+/- <10) area: popm This is a change to popm (PoP Miner) labels May 17, 2024
@joshuasing joshuasing changed the title popmd: remove unused 'handle' func popmd: remove unused 'handle' func and return err in connectBFG May 17, 2024
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joshuasing joshuasing merged commit cf7c570 into main May 20, 2024
1 check passed
@joshuasing joshuasing deleted the joshua/popm-tidy branch May 20, 2024 15:37
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: popm This is a change to popm (PoP Miner) size: XS This change is very small (+/- <10) type: bug This is a bug type: refactor This refactors existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants