Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix bug that makes version type always 'unstable' #125

Merged
merged 1 commit into from
May 20, 2024

Conversation

joshuasing
Copy link
Contributor

Summary
Adds a missing $ character that causes the version type to always be set to 'unstable' in the release workflow.

Changes

  • Fix version type check in release workflow prepare step

@joshuasing joshuasing added type: bug This is a bug area: ci This is a change to CI files. Excluded from changelog labels May 17, 2024
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joshuasing joshuasing merged commit fa2a4c4 into main May 20, 2024
1 check passed
@joshuasing joshuasing deleted the joshua/ci-release-bug branch May 20, 2024 15:37
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci This is a change to CI files. Excluded from changelog type: bug This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants