remove bug (and ineffiency) from MATERIALIZED VIEW #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, in our canonical chain MATERIALIZED VIEW, we would fall back to height if we couldn't find a previous block by hash, this is incorrect (and inefficient), so remove it
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
|
hold on...seeing one more bug 🐛 |
|
there might be a larger issue going on here, converting to draft |
ClaytonNorthey92
removed request for
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
|
closing until other issue is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
previously, in our canonical chain MATERIALIZED VIEW, we would fall back to height if we couldn't find a previous block by hash
Changes
the aforementioned is incorrect (and inefficient), so remove it