Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bfg: fix issues reported by staticcheck #132

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

joshuasing
Copy link
Contributor

Summary
Fix issues reported by staticcheck for code related to bfg

Changes

  • Fix github.com/btcsuite/btcd/wire being imported more than once (ST1019)
  • Simplify error comparison (S1002)
  • Remove unused fields and variables

@joshuasing joshuasing added type: refactor This refactors existing functionality area: bfg This is a change to BFG (Bitcoin Finality Governor) labels May 22, 2024
@joshuasing joshuasing changed the title Fix github.com/btcsuite/btcd/wire being imported more than once (ST1019) bfg: fix issues reported by staticcheck May 22, 2024
@joshuasing joshuasing added the size: S This change is small (+/- <80) label May 22, 2024
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joshuasing joshuasing merged commit 723b637 into main May 28, 2024
1 check passed
@joshuasing joshuasing deleted the joshua/bfg-staticcheck branch May 28, 2024 13:38
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: bfg This is a change to BFG (Bitcoin Finality Governor) size: S This change is small (+/- <80) type: refactor This refactors existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants