Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrumx: fix unhandled error in NewJSONRPCRequest #133

Merged
merged 1 commit into from
May 28, 2024
Merged

electrumx: fix unhandled error in NewJSONRPCRequest #133

merged 1 commit into from
May 28, 2024

Conversation

joshuasing
Copy link
Contributor

Summary
Fix unhandled error from json.Marshal in NewJSONRPCRequest function.

Changes

  • Add error return value to NewJSONRPCRequest
  • Return error from json.Marshal error in NewJSONRPCRequest
  • Handle errors from NewJSONRPCRequest

@joshuasing joshuasing added type: refactor This refactors existing functionality size: S This change is small (+/- <80) labels May 22, 2024
jcvernaleo
jcvernaleo approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joshuasing joshuasing merged commit 509fb1b into main May 28, 2024
1 check passed
@joshuasing joshuasing deleted the joshua/fix-electrumx-unhandled-err branch May 28, 2024 13:38
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
@joshuasing
electrumx: fix unhandled error in NewJSONRPCRequest (hemilabs#133)
21ba5a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaytonNorthey92 ClaytonNorthey92 ClaytonNorthey92 approved these changes

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@marcopeereboom marcopeereboom Awaiting requested review from marcopeereboom

Assignees
No one assigned
Labels
size: S This change is small (+/- <80) type: refactor This refactors existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuasing @jcvernaleo @ClaytonNorthey92