Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix issues detected by staticcheck #134

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

joshuasing
Copy link
Contributor

Summary
Fix issues reported by staticcheck for code in the e2e directory.

Changes

  • Remove unused wg and addr fields from bssWs
  • Remove unused createPopm function
  • Fix ineffective break statements
  • Rename variables prefixed with _

@joshuasing joshuasing added type: refactor This refactors existing functionality area: test This adds or improves test coverage size: M This change is medium (+/- <200) labels May 27, 2024
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joshuasing joshuasing merged commit 12eefff into main Jun 4, 2024
1 check passed
@joshuasing joshuasing deleted the joshua/staticcheck-e2e branch June 4, 2024 14:45
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: test This adds or improves test coverage size: M This change is medium (+/- <200) type: refactor This refactors existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants