Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore ulimits in tbc when on localnet #142

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ClaytonNorthey92
Copy link
Contributor

Summary
localnet is small, and is easy for tbc to crawl and index. with localnet, we often run it in CI environments where we have limited or no control over ulimits. there is no need for this in localnet, so let's ignore it if we're on localnet.

Changes
if network set to localnet, ignore ulimits

localnet is small, and is easy for tbc to crawl and index.  with localnet, we often run it in CI environments where we have limited or no control over ulimits.  there is no need for this in localnet, so let's ignore it if we're on localnet.
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. If localnet ever gets that big, we are using it wrong.

OK

@ClaytonNorthey92 ClaytonNorthey92 merged commit bbeed8b into main Jun 6, 2024
1 check passed
@ClaytonNorthey92 ClaytonNorthey92 deleted the clayton/no-ulimit-localnet branch June 6, 2024 14:53
@joshuasing joshuasing added type: refactor This refactors existing functionality type: bug This is a bug area: tbc This is a change to TBC (Tiny Bitcoin) labels Jul 1, 2024
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
localnet is small, and is easy for tbc to crawl and index.  with localnet, we often run it in CI environments where we have limited or no control over ulimits.  there is no need for this in localnet, so let's ignore it if we're on localnet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tbc This is a change to TBC (Tiny Bitcoin) type: bug This is a bug type: refactor This refactors existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants