Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial CODEOWNERS file #149

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add initial CODEOWNERS file #149

merged 1 commit into from
Jun 24, 2024

Conversation

joshuasing
Copy link
Contributor

@joshuasing joshuasing commented Jun 13, 2024 •
edited
Loading

Summary
Add initial .github/CODEOWNERS file (GitHub documentation).

This file is useful for both security, as well as efficiency/automation.
People with experience in certain areas of the codebase will be automatically requested to review incoming changes, giving the right people a chance to review the pull request before it is merged.

In the future, branch protection rules could be used to enforce that at least one code owner "signs off" on the changes, however this has not been done yet.

Changes

  • Add .github/CODEOWNERS

@joshuasing joshuasing added type: enhancement This improves existing functionality size: XS This change is very small (+/- <10) labels Jun 13, 2024
jcvernaleo
jcvernaleo approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

marcopeereboom
marcopeereboom approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@marcopeereboom marcopeereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is worth having but don't oppose it. I can't see a universe where this isn't stale.

@joshuasing joshuasing merged commit 3df5001 into main Jun 24, 2024
4 checks passed
@joshuasing joshuasing deleted the joshua/codeowners branch June 24, 2024 09:37
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
@joshuasing
Add initial CODEOWNERS file (hemilabs#149)
6f2c084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcopeereboom marcopeereboom marcopeereboom approved these changes

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@ClaytonNorthey92 ClaytonNorthey92 Awaiting requested review from ClaytonNorthey92

@max-sanchez max-sanchez Awaiting requested review from max-sanchez

Assignees
No one assigned
Labels
size: XS This change is very small (+/- <10) type: enhancement This improves existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuasing @jcvernaleo @marcopeereboom