popm/wasm: add error codes #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
requested changes
Jun 24, 2024
joshuasing
requested review from
marcopeereboom,
jcvernaleo and
ClaytonNorthey92
ClaytonNorthey92
approved these changes
Jun 24, 2024
joshuasing
force-pushed
the
joshua/wasm-popm-err-code
branch
from
72f406d
to
9491665
Compare
marcopeereboom
requested changes
Jun 26, 2024
marcopeereboom
approved these changes
Jun 27, 2024
joshuasing
added
type: enhancement
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Add error codes to the WebAssembly PoP Miner. These error codes exposed in the NPM package for easy programatically handling different error types. Reviewed-on: hemilabs#154 Reviewed-by: ClaytonNorthey92 <clayton.northey@gmail.com> Reviewed-by: Marco Peereboom <marco@peereboom.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add error codes to the WebAssembly PoP Miner.
These error codes will be used to programatically handle errors and display useful information to users.
The default error code is ErrorCodeInternal ("internal").
Changes
ErrorCodetype and addCodefield to the existingErrortypeErrorCodeInternalfor use with internal errors (and is the default error code)ErrorCodeInvalidValuefor use when an invalid value is provided for an argument, currently only used ingenerateKeycodedErrortype, used to include an error code in an error that is extracted when creating anErrorthat will be converted to a JavaScript ObjectMore error codes will be added as needed in future pull requests.