tbc: allow seeds to be overwritten #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if cfg seeds are set, use those, otherwise use the defaults for the network chosen
joshuasing
reviewed
Jun 24, 2024
marcopeereboom
requested changes
Jun 25, 2024
joshuasing
requested changes
Jun 25, 2024
joshuasing
reviewed
Jun 25, 2024
joshuasing
reviewed
Jun 25, 2024
ah yes I had forgottent we have the command (I was thinking of only |
joshuasing
reviewed
Jun 25, 2024
Co-authored-by: Joshua Sing <joshua@bloq.com>
joshuasing
reviewed
Jun 25, 2024
joshuasing
reviewed
Jun 25, 2024
Co-authored-by: Joshua Sing <joshua@bloq.com>
joshuasing
reviewed
Jun 25, 2024
marcopeereboom
approved these changes
Jun 26, 2024
joshuasing
reviewed
Jun 26, 2024
joshuasing
reviewed
Jun 26, 2024
Co-authored-by: Joshua Sing <joshua@bloq.com>
ClaytonNorthey92
changed the title
joshuasing
approved these changes
Jun 26, 2024
joshuasing
added
type: refactor
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
* allow TBC seeds to be overwritten if cfg seeds are set, use those, otherwise use the defaults for the network chosen * fixed missing seeding * remove tbc Server.port * using string for seeds * use host for lookupip * added TBC_SEEDS env config * Update service/tbc/tbc.go Co-authored-by: Joshua Sing <joshua@bloq.com> * simplify NewPeer in localPeerManager * Update cmd/tbcd/tbcd.go Co-authored-by: Joshua Sing <joshua@bloq.com> * use AppendSlice * removed ports from variables * fix reflect handling of seeds * Update config/config.go Co-authored-by: Joshua Sing <joshua@bloq.com> * using 127.0.0.1 as default IP/host for localnet --------- Co-authored-by: Joshua Sing <joshua@bloq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
allow tbc seeds to be overwritten
Changes
if cfg seeds are set, use those, otherwise use the defaults for the network chosen
fixes #157