popm/wasm: add new @hemilabs/pop-miner NPM package #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
added
type: enhancement
joshuasing
requested review from
jcvernaleo,
marcopeereboom,
ClaytonNorthey92 and
ArturDolzan
marcopeereboom
previously approved these changes
Jul 1, 2024
marcopeereboom
approved these changes
Jul 1, 2024
jcvernaleo
approved these changes
Jul 1, 2024
ArturDolzan
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
We discussed a couple of things on slack, like how the front-end would provide the scriptHash to call the bitcoin balance or utxos functions, or when the user input a bitcoin private key only, how the front-end would know all the other info that is provided by generating a new key, or how the front-end will render the transactions list table, where the user will see the latests blocks and its status.
These are topics for future PR's, so LGTM.
gndelia
reviewed
Jul 1, 2024
gndelia
reviewed
Jul 1, 2024
gndelia
approved these changes
Jul 1, 2024
#162 (comment) Suggested-by: Gonzalo D'Elia <gonzalo@bloq.com>
gndelia
reviewed
Jul 2, 2024
gndelia
approved these changes
Jul 2, 2024
ClaytonNorthey92
approved these changes
Jul 2, 2024
1 task
joshuasing
added
type: feature
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Add the initial implementation of the `@hemilabs/pop-miner` NPM package, a TypeScript API layer for the WebAssembly PoP Miner. Also adds supporting files, GitHub Actions workflow changes to build and publish the NPM package. This is the initial version of this package, more functionality will be added in future pull requests. Reviewed-on: hemilabs#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
@hemilabs/pop-minerpackage, a TypeScript API for the WebAssembly PoP Miner.Changes
@hemilabs/pop-minerpackage (web/packages/pop-miner) and supporting filesThis is the initial version of this package, more functionality will be added in future pull requests.
This contains more than +9K line changes, however the majority of this is from the PNPM lock files and can be ignored.