popm/wasm: fix ethereum address when generating and parsing keys #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
requested review from
jcvernaleo,
marcopeereboom,
ClaytonNorthey92 and
ArturDolzan
github-actions
bot
added
the
area: popm/wasm
ClaytonNorthey92
approved these changes
Jul 10, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
…ilabs#174) Use uncompressed serialised secp256k1 public key to create Ethereum addresses. Previously, the compressed serialised secp256k1 public key was used, which resulted in a different value being provided as the address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use uncompressed serialised secp256k1 public key to create the Ethereum address.
Previously, the compressed serialised secp256k1 public key was used, which resulted in a different value being provided as the address.
Changes