Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popm/wasm: fix dispatch params for {add,remove}EventListener #181

Merged
merged 1 commit into from
Jul 15, 2024
Merged

popm/wasm: fix dispatch params for {add,remove}EventListener #181

merged 1 commit into from
Jul 15, 2024

Conversation

joshuasing
Copy link
Contributor

Summary
Fix dispatch params for addEventListener and removeEventListener in the @hemilabs/pop-miner package.

Changes

  • Change listener param to handler in the addEventListener and removeEventListener functions in the pop-miner NPM package.

@joshuasing joshuasing added type: bug This is a bug size: XS This change is very small (+/- <10) labels Jul 15, 2024
@joshuasing joshuasing requested a review from a team as a code owner July 15, 2024 15:57
@github-actions github-actions bot added the area: @hemilabs/pop-miner This is a change to the @hemilabs/pop-miner NPM package label Jul 15, 2024
@joshuasing joshuasing merged commit 1f168f2 into main Jul 15, 2024
6 checks passed
@joshuasing joshuasing deleted the joshua/popm/fix-event-functions branch July 15, 2024 16:07
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
@joshuasing
popm/wasm: fix dispatch params for {add,remove}EventListener (hemilab…
c4327a0 
…s#181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturDolzan ArturDolzan ArturDolzan approved these changes

@ClaytonNorthey92 ClaytonNorthey92 ClaytonNorthey92 approved these changes

@jcvernaleo jcvernaleo Awaiting requested review from jcvernaleo

Assignees
No one assigned
Labels
area: @hemilabs/pop-miner This is a change to the @hemilabs/pop-miner NPM package size: XS This change is very small (+/- <10) type: bug This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuasing @ClaytonNorthey92 @ArturDolzan