-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow connection of BFG to another BFG for L2 Keystone Notifications/Querying #286
Open
ClaytonNorthey92
wants to merge
6
commits into
main
Choose a base branch
from
clayton/connected-bfgs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: bfg
This is a change to BFG (Bitcoin Finality Governor)
label
Oct 18, 2024
ClaytonNorthey92
force-pushed
the
clayton/connected-bfgs
branch
2 times, most recently
from
October 18, 2024 19:18
4fe85f5
to
4f458f7
Compare
ClaytonNorthey92
changed the title
Clayton/connected bfgs
Allow connection of BFG to another BFG for L2 Keystone Notifications/Querying
Oct 18, 2024
github-actions
bot
added
the
area: ci
This is a change to CI files. Excluded from changelog
label
Oct 21, 2024
ClaytonNorthey92
force-pushed
the
clayton/connected-bfgs
branch
2 times, most recently
from
October 21, 2024 20:26
331df9e
to
b768be5
Compare
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
October 21, 2024 20:27
joshuasing
requested changes
Oct 23, 2024
ClaytonNorthey92
force-pushed
the
clayton/connected-bfgs
branch
3 times, most recently
from
October 25, 2024 16:09
d809324
to
7a12aa5
Compare
…ions allow a BFG to connect to another BFG. the client BFG will receive L2 Keystone notifications via the public websocket endpoint, it will then query for new keystones when it gets a notification. you must use BFG_BFG_URL + BFG_BTC_PRIVKEY to connect to another BFG. BFG will request the latest 3 keystones upon each notification then save them in the DB and broadcast the keystones to its connected clients add ON CONFLICT DO NOTHING to no-op with keystones we've already received updated readme
Co-authored-by: Joshua Sing <joshua@bloq.com>
ClaytonNorthey92
force-pushed
the
clayton/connected-bfgs
branch
from
October 25, 2024 16:18
7a12aa5
to
cdc0190
Compare
joshuasing
reviewed
Oct 25, 2024
joshuasing
reviewed
Oct 25, 2024
joshuasing
approved these changes
Oct 25, 2024
Co-authored-by: Joshua Sing <joshua@bloq.com>
Co-authored-by: Joshua Sing <joshua@bloq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to make BFGs easier to run. This PR will do so by allow a BFG (ex. run by a PoP miner) to receive l2 keystones from another, trusted BFG (example Hemi Labs) and use a local Electrs+bitcoind to broadcast the transaction instead of Hemi Labs (or any third party). This will avoid congestion during: btc balance retrieval, btc utxos retrieval, btc height retrieval, and btc broadcasting.
fixes #261
Changes
allow a BFG to connect to another BFG. the client BFG will receive L2 Keystone notifications via the public websocket endpoint, it will then query for new keystones when it gets a notification.
you must use BFG_BFG_URL + BFG_BTC_PRIVKEY to connect to another BFG.
BFG will request the latest 3 keystones upon each notification then save them in the DB and broadcast the keystones to its connected clients
add ON CONFLICT DO NOTHING to no-op with keystones we've already received
updated readme