Try to prevent header download stalls. #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
force-pushed
the
marco/headers
branch
from
af21cf2
to
30919b6
Compare
joshuasing
reviewed
Nov 1, 2024
ClaytonNorthey92
approved these changes
Nov 1, 2024
Instead of walking a path always back to genesis compare all hashes in the path instead of one entire path at a time.
Also add a new error type in database so that the caller can figure out which block is missing.
marcopeereboom
force-pushed
the
marco/headers
branch
from
e0773d0
to
71b1549
Compare
joshuasing
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes