electrumx: fix race condition in client #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
added
type: bug
joshuasing
force-pushed
the
joshua/electrumx-race
branch
from
4a2afcc
to
dc75bc0
Compare
Previously, the request ID stored in the client was incremented while the lock was held, however it was then read without the lock being held.
joshuasing
force-pushed
the
joshua/electrumx-race
branch
from
dc75bc0
to
650f198
Compare
ClaytonNorthey92
approved these changes
Feb 26, 2024
joshuasing
changed the title
marcopeereboom
approved these changes
Feb 27, 2024
@marcopeereboom I am not sure, this was the previous behaviour except with the read in a lock. |
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Previously, the request ID stored in the client was incremented while the lock was held, however it was then read without the lock being held.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a race condition in the electrumx client
Previously, the request ID stored in the client was incremented while the lock was held, however it was then read without the lock being held.
Changes
electrumxpackage