Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 2024-04-03 #10

Closed
gabmontes opened this issue Apr 3, 2024 · 18 comments
Closed

Deploy 2024-04-03 #10

gabmontes opened this issue Apr 3, 2024 · 18 comments
Assignees

Comments

@gabmontes
Copy link

@dhidalgX please deploy the Hemi PF app. Instructions in the README.md file.

@dhidalgX
Copy link

dhidalgX commented Apr 3, 2024

@gabmontes Please create a running docker image to be deployed.
cc'd: @jcvernaleo

@gabmontes
Copy link
Author

@dhidalgX this is a 100% static file. What do we need a Docker image for?

@dhidalgX
Copy link

dhidalgX commented Apr 3, 2024

@gabmontes Oh ok, thanks for clarifying.

@dhidalgX
Copy link

dhidalgX commented Apr 3, 2024

So in this case, i will just need to focus on the deployment portion...
deployment

@gabmontes please confirm.
cc'd: @jcvernaleo

@gabmontes
Copy link
Author

@dhidalgX yes. That's exactly what I requested in #10 (comment). 😄

@dhidalgX
Copy link

dhidalgX commented Apr 3, 2024

@jcvernaleo Do we have a desire link for pure.finance?

f.e:
hemi.xyz/pure.finance ?

@jcvernaleo
Copy link

Yes, that works for me.

@gabmontes
Copy link
Author

That may not work. The site is configured to be built and hosted in a domain or a subdomain, not below a path.

Let's consider tools.hemi.xyz or something like that.

@dhidalgX
Copy link

dhidalgX commented Apr 3, 2024

@gabmontes There is a business need, as a understand to use path related links instead of subdomains. @jcvernaleo Maybe you could explain better.
From our side, we have not setup any path related links so far, at this moment all of them are subdomains.

@gabmontes
Copy link
Author

@dhidalgX ok. Proceed with the deploy. If the app does not render properly, we will fix that.

@jcvernaleo
Copy link

The reason for the desired URL was at @philgomes 's request for SEO related black magic.

But if fixing PF for that is too much work we can always do subdomain for this as a special case.

@gabmontes
Copy link
Author

Is ok. Let's try and if fails, we will fix the problem. I think it is just a few params in Next's config.

@gabmontes
Copy link
Author

gabmontes commented Apr 4, 2024

@dhidalgX please proceed with the deploy once #12 is merged. Set BASE_PATH at build time as described in the docs.

@dhidalgX
Copy link

dhidalgX commented Apr 4, 2024

@jcvernaleo @gabmontes I will need to create some secrets for deployment automation and admin access to https://github.com/hemilabs/pure.finance repo

@dhidalgX
Copy link

dhidalgX commented Apr 4, 2024

@jcvernaleo @gabmontes for now https://purefinance.hemi.xyz is enabled, still need to work on path links as required.

@gabmontes
Copy link
Author

@gabmontes
Copy link
Author

@dhidalgX this is done, right?

@dhidalgX
Copy link

@gabmontes Yes, this issue is solved, was realated to SSH keys with Hostinger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants