Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed layout problems #44

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fixed layout problems #44

merged 2 commits into from
Oct 18, 2024

Conversation

alvarengathomas
Copy link

@alvarengathomas alvarengathomas commented Oct 17, 2024

This PR includes fixes for most of the problems @dvnahuel requested in the following link:
https://www.figma.com/design/4fVd9wneclsvYDYD95ApZ9/Hemi-Portal?node-id=5546-22666&t=KHgKWmnEqCtX1I5C-1

The list below shows the fixes done in this PR:

  • (Landing Page) Border color is different
  • (Landing Page) The box is missing the shadow
  • (Landing Page) on-hover the background whould be grayscale/50
  • (Landing Page) Footer here is full width, it should only occupy the width of the cards container
  • (Landing Page) Border is different color and with wider border
  • (Landing Page) On-hover this socials should be grayscale/950
  • (Tools Page) Arrow icon is different from design
  • (Tools Page) Space between these elements should be 8px
  • (Tools Page) Space between this elements and the text on the top should be 16px
  • (Tools Page) The space between these containers should be 16px
  • (Tools Page) Let’s remove the footer border and adjust the margins, these should be 24px bottom left and right, bot elements should be with with space-between property
  • (Tools Page) Left section container should be 100% VH with 8px of margin
  • (Tools Page) The header should be with the same margins as in the landing page (20px top, 24 right)
  • (Tools Page) Background color here should be white
  • (Tools Page) We should use validations, at least native ones in this case, ‘CLAIM’ should be disabled until the user inputs an ID

The pending fixes are:

  • (Tools Page) Let’s use rainbow kit for wallet management

    It will require a big refactor to change wallet management to rainbow kit

  • (Tools Page) I should be able to click the inputs here

    The inputs are only enabled when the wallet is connected

Copy link

@ArturDolzan ArturDolzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments otherwise LGTM

site/components/layout/HomeFooter.js Outdated Show resolved Hide resolved
site/components/layout/ToolsFooter.js Outdated Show resolved Hide resolved
@gndelia
Copy link

gndelia commented Oct 17, 2024

Hey there! Can we get a few screenshots to better see the visual updates?

@alvarengathomas
Copy link
Author

Hey there! Can we get a few screenshots to better see the visual updates?

There is no much difference in the visuals, just minor details as you can see below:

Landing Page (Before this PR):
old-landing-page

Landing Page (After this PR):
new-landing-page

Tools Page (Before this PR):
old-tools-page

Tools Page (After this PR):
new-tools-page

Copy link

@gabmontes gabmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alvarengathomas please replace the social links with hemi-socials in a follow-up PR, so we don't block this one.

@alvarengathomas alvarengathomas merged commit 53878d8 into master Oct 18, 2024
3 checks passed
@alvarengathomas alvarengathomas deleted the fix-layout branch October 18, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants