Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed token revokes empty states messages #60

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

alvarengathomas
Copy link

Closes #49

This PR includes:

  • Improvement of token revokes empty states

Connect Wallet

Before PR:
Captura de Tela 2024-12-16 às 11 59 03

After PR:
Captura de Tela 2024-12-16 às 11 57 21


Loading

Before PR:
Captura de Tela 2024-12-16 às 11 59 44

After PR:
Captura de Tela 2024-12-16 às 11 57 04


Empty List

Before PR:
Captura de Tela 2024-12-16 às 12 03 21

After PR:
Captura de Tela 2024-12-16 às 11 56 33

@dvnahuel
Copy link

As minor points of improvement, I’d suggest

  • Removing the scroll bar from the empty states (since there are no items to scroll through).

  • Adding a border radius to the label container. The border radius should follow this logic: Parent container border radius - (minus) Container margin from the parent container = Label container border radius.

  • Adding the following box-shadow to the displayed white container: box-shadow: 0px 2px 4px 0px rgba(0, 2, 2, 0.04), 0px 8px 24px -4px rgba(0, 2, 2, 0.04);

  • Making the loader color orange #FF6C15

Copy link

@ArturDolzan ArturDolzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single comment otherwise LGTM.

site/pages/[locale]/token-revokes.js Show resolved Hide resolved
@ArturDolzan ArturDolzan self-requested a review December 17, 2024 13:46
ArturDolzan
ArturDolzan previously approved these changes Dec 17, 2024
@alvarengathomas
Copy link
Author

alvarengathomas commented Dec 17, 2024

As minor points of improvement, I’d suggest

  • Removing the scroll bar from the empty states (since there are no items to scroll through).
  • Adding a border radius to the label container. The border radius should follow this logic: Parent container border radius - (minus) Container margin from the parent container = Label container border radius.
  • Adding the following box-shadow to the displayed white container: box-shadow: 0px 2px 4px 0px rgba(0, 2, 2, 0.04), 0px 8px 24px -4px rgba(0, 2, 2, 0.04);
  • Making the loader color orange #FF6C15

@dvnahuel I managed to fix most of the things you asked for (with a few caveats):

  • Removing the scroll bar from the empty states.
  • Adding a border radius to the label container.

I tried a lot to add this border-radius the first time I refactored this component and tried again now and I could not do it, I think the problem is the <table> element, maybe we can change it to a grid in the future to apply this border-radius

  • Adding box-shadow to the white container.

I could not add the custom box-shadow you asked for, but I could apply the tailwind's default one:

.shadow-lg {
    --tw-shadow: 0 10px 15px -3px rgba(0, 0, 0, 0.1), 0 4px 6px -2px rgba(0, 0, 0, 0.05);
    box-shadow: var(--tw-ring-offset-shadow, 0 0 #0000), var(--tw-ring-shadow, 0 0 #0000), var(--tw-shadow);
}
  • Making the loader color orange #FF6C15.

Final result:
Captura de Tela 2024-12-17 às 10 41 16

@gndelia gndelia merged commit d980e2e into master Dec 20, 2024
6 checks passed
@gndelia gndelia deleted the fix-revokes-empty-states branch December 20, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Empty States for List and Revoke Token Approvals
5 participants