Better display for MidiThing for module browser

hemmer · Apr 23, 2024 · 733acea · 733acea
1 parent 1cb0e9f
commit 733acea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/build-plugin.yml b/.github/workflows/build-plugin.yml
@@ -2,7 +2,7 @@ name: Build VCV Rack Plugin
 on: [push, pull_request]
 
 env:
-  rack-sdk-version: 2.4.1
+  rack-sdk-version: 2.5.1
   rack-plugin-toolchain-dir: /home/build/rack-plugin-toolchain
 
 defaults:

diff --git a/src/MidiThing.cpp b/src/MidiThing.cpp
@@ -485,10 +485,16 @@ struct LEDDisplay : LightWidget {
 
 		if (font && font->handle >= 0) {
 
-			std::string text = "?-?v";  // fallback if module not yet defined
+			std::string text;
 			if (module) {
 				text = module->cfgPortModeNames[module->getVoltageMode(row, col) + 1];
 			}
+			else {
+				// fallback if module not yet defined
+				const char* cfgPortModeNames[5] = {"0/10v", "-5/5v", "-10/0v", "0/8v", "0/5v"};
+				const int randomModeForDisplay = rack::random::u32() % 5;
+				text = cfgPortModeNames[randomModeForDisplay];
+			}
 			char buffer[numChars + 1];
 			int l = text.size();
 			if (l > numChars)