Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add horizontal scrolling and improve layout #38

Merged
merged 8 commits into from
Jan 11, 2025
Merged

feat: add horizontal scrolling and improve layout #38

merged 8 commits into from
Jan 11, 2025

Conversation

herrschmidt
Copy link
Owner

Changes

Horizontal Scrolling

  • Added middle mouse button horizontal scrolling for tables
  • Added visual feedback with grab/grabbing cursors
  • Improved scroll handling with document-level event listeners
  • Fixed scrolling container structure

Layout Improvements

  • Reduced spacing between drag-drop and footer when no result is shown
  • Improved code organization and removed duplicates
  • Added safety checks for scroll handlers

Testing

  1. Upload a document with wide tables
  2. Test horizontal scrolling:
    • Using middle mouse button (press and drag)
    • Using regular scrollbar
  3. Verify cursor feedback when scrolling
  4. Check layout spacing before and after conversion

@herrschmidt herrschmidt marked this pull request as ready for review January 11, 2025 14:28
@herrschmidt herrschmidt merged commit 6ad6fb0 into main Jan 11, 2025
1 check failed
@herrschmidt herrschmidt deleted the improve-scrolling-and-layout branch January 11, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herrschmidt @openhands-agent